Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] Production site with Expired Key watermark #13032

Closed
exosept opened this issue May 6, 2024 · 7 comments
Closed

[data grid] Production site with Expired Key watermark #13032

exosept opened this issue May 6, 2024 · 7 comments
Labels
package: x-license Specific to @mui/x-license. status: waiting for author Issue with insufficient information support: commercial Support request from paid users support: premium standard Support request from a Premium standard plan user. https://mui.com/legal/technical-support-sla/

Comments

@exosept
Copy link

exosept commented May 6, 2024

The problem in depth

What is considered a production environment vs a dev environment for the license keys to display the watermark?
I am hosting the react site on firebase and didn't make change for at least 6 months but the watermark appeared on the day that the license expired. I renewed the license but the old keys still seems to be marked as expired. How can I indicate that the build is for production so the watermark will not appear everywhere in prod each year? Thanks a lo.

Your environment

System:
OS: macOS 13.5
Binaries:
Node: 20.11.0 - /usr/local/bin/node
npm: 10.2.4 - /usr/local/bin/npm
pnpm: Not Found
Browsers:
Chrome: 124.0.6367.119
Edge: Not Found
Safari: 16.6

Search keywords: key expired
Order ID: 89823

@exosept exosept added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: commercial Support request from paid users labels May 6, 2024
@michelengelen michelengelen added package: x-license Specific to @mui/x-license. support: premium standard Support request from a Premium standard plan user. https://mui.com/legal/technical-support-sla/ labels May 7, 2024
@michelengelen michelengelen changed the title Production site with Expired Key watermark [data grid] Production site with Expired Key watermark May 7, 2024
@michelengelen
Copy link
Member

Hey @exosept
As stated in this section of the docs you need to make sure that the version you are installing was released before your license expires. One possibility is to pin down the specific version in your build scripts.

@michelengelen michelengelen added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels May 7, 2024
@exosept
Copy link
Author

exosept commented May 7, 2024

Hi Michele, thanks for your reply. I bought the tools in May 2023 and been using that version ever since. The last built occured in october 2023. It's not been modified, rebuilt or republished to Firebase ever since. That's why I do not understand why I started to get the expired message on May 2024.

@github-actions github-actions bot added status: waiting for maintainer These issues haven't been looked at yet by a maintainer and removed status: waiting for author Issue with insufficient information labels May 7, 2024
@michelengelen
Copy link
Member

@joserodolfofreitas I am not too familiar with the license implications. Could you jump in here?

@flaviendelangle
Copy link
Member

Here is the description of "annual license", which I guess is the one you have:

image

My guess is that the build your deployed application is using is a development build.

We are using process.env.NODE_ENV === 'production' for our checks, if your build is not configured correctly it would explain the problem.

Note that a dev build deployed in production has other implications outside of MUI X, you would be using the dev mode of React which is by far less performant than the prod one, the bundle would probably not be optimized in size etc...

To check this, you could log the following a deploy your website in some test environment:

console.log('ENV', process.env.NODE_ENV)

If it logs production, then the problem comes from something else 😬

@exosept
Copy link
Author

exosept commented May 7, 2024

Thanks a lot, you answered my question.

@michelengelen
Copy link
Member

Thanks @flaviendelangle ... I did not check the license verification 🤦🏼

@exosept feel free to close this if the issue is resolved for you!

@michelengelen michelengelen added status: waiting for author Issue with insufficient information and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels May 8, 2024
Copy link

The issue has been inactive for 7 days and has been automatically closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: x-license Specific to @mui/x-license. status: waiting for author Issue with insufficient information support: commercial Support request from paid users support: premium standard Support request from a Premium standard plan user. https://mui.com/legal/technical-support-sla/
Projects
None yet
Development

No branches or pull requests

3 participants