-
-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
[studio] Cell shouldn't be editable by default #3524
Comments
Hi, @oliviertassinari. Would love to take up this issue, but I'm stuck at understanding the issue.
This is what I did understand, please let me know if it's not the case, and in case the it's same is it possible for me take up this one? |
@b4s36t4 The data grid should only be editable when it is linked to a data provider that supports editing rows. In all other cases there won't be any logic available to handle the row updates, so having the grid editable makes no sense. As you may notice in the live example, you can change the value of the cel, but as soon as you exit editing mode, the value is reset again. This is meant to be a static grid, output only. |
@Janpot I have raised a PR, please check it.! |
Steps to reproduce
Screen.Recording.2024-05-05.at.18.16.29.mov
Context
I suspect #3001 is the origin of this regression. I noticed this one on the same app that I noticed the other regressions from (the Zendesk plugin), while I was fixing https://github.com/mui/mui-private/pull/470.
Benchmarks
The text was updated successfully, but these errors were encountered: