Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][FormControlLabel] Fix applying of slotprops #42303

Open
wants to merge 7 commits into
base: next
Choose a base branch
from
Open

[material-ui][FormControlLabel] Fix applying of slotprops #42303

wants to merge 7 commits into from

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented May 20, 2024

closes #42277

@sai6855 sai6855 marked this pull request as draft May 20, 2024 05:28
@sai6855 sai6855 changed the title [material-ui][FormControlLabel] Fix slotprops [material-ui][FormControlLabel] Fix applying of slotprops May 20, 2024
@mui-bot
Copy link

mui-bot commented May 20, 2024 •
edited

Netlify deploy preview

https://deploy-preview-42303--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against f330be8

@sai6855 sai6855 added bug 🐛 Something doesn't work package: material-ui Specific to @mui/material component: FormControl The React component labels May 20, 2024
@sai6855
Copy link
Contributor Author

sai6855 commented May 20, 2024

I don't think argos change is related to this PR, reason being neither FormControlLabel or Typography components are used to render chart

sai6855
sai6855 commented May 20, 2024
View reviewed changes
packages/mui-material/src/FormControlLabel/FormControlLabel.test.js
Comment on lines +349 to +351
expect(getByTestId('typography')).to.have.style('white-space', 'nowrap');
expect(getByTestId('typography')).to.have.style('overflow', 'hidden');
expect(getByTestId('typography')).to.have.style('text-overflow', 'ellipsis');
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are styles applied when noWrap is passed to typography

material-ui/packages/mui-material/src/Typography/Typography.js

Lines 81 to 86 in 9b2e523

style: {
overflow: 'hidden',
textOverflow: 'ellipsis',
whiteSpace: 'nowrap',
},
},

@sai6855 sai6855 requested a review from DiegoAndai May 20, 2024 06:29
@sai6855 sai6855 marked this pull request as ready for review May 20, 2024 06:29
@sai6855 sai6855 mentioned this pull request May 23, 2024
Open
@DiegoAndai
Copy link
Member

Hey @sai6855, thanks for working on this

Does #42358 fix it?

@sai6855 sai6855 force-pushed the fix-slotprops-formcontrollabel branch from 7ec4f67 to eecb0a2 Compare May 24, 2024 03:47
@sai6855
Copy link
Contributor Author

sai6855 commented May 24, 2024

Does #42358 fix it?

yes, it did. tried your fix in this commit eecb0a2 and newly added test is passing, also checked manually whether styles are getting applied properly.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 28, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DiegoAndai DiegoAndai Awaiting requested review from DiegoAndai

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: FormControl The React component package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[material-ui][FormControlLabel] slotProps.typography not applied correctly
3 participants
@sai6855 @mui-bot @DiegoAndai