Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[slider] Incorrect CSS position on vertical slider indicator #1480

Open
EliotSlevin opened this issue Feb 26, 2025 · 2 comments
Open

[slider] Incorrect CSS position on vertical slider indicator #1480

EliotSlevin opened this issue Feb 26, 2025 · 2 comments
Labels
bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module! has workaround ready to take Help wanted. Guidance available. There is a high chance the change will be accepted

Comments

@EliotSlevin
Copy link

Vertical sliders seem to be doing this:

Screen.Recording.2025-02-26.at.00.58.35.mov

Base-ui is adding the following styles inline as you move:

    position: relative;
    bottom: 0px;
    height: 74%; // changes based on thumb position

I think this should instead be position: absolute?

@EliotSlevin EliotSlevin added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Feb 26, 2025
@mj12albert mj12albert changed the title The progress gets out of sync with the thumb on vertical sliders [Slider] Incorrect Indicator positioning on vertical sliders Feb 26, 2025
@mj12albert mj12albert added component: slider This is the name of the generic UI component, not the React module! bug 🐛 Something doesn't work labels Feb 26, 2025
@mj12albert
Copy link
Member

@EliotSlevin You're right, vertical sliders were overlooked when this was decided in #981 (comment)

We should make it relative when horizontal and absolute when vertical, in the mean time you can override it with !important in your styles as a workaround

@mj12albert mj12albert added has workaround and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Feb 26, 2025
@github-project-automation github-project-automation bot moved this to Backlog in Base UI Feb 26, 2025
@mj12albert mj12albert added the ready to take Help wanted. Guidance available. There is a high chance the change will be accepted label Feb 26, 2025
@mj12albert mj12albert changed the title [Slider] Incorrect Indicator positioning on vertical sliders [Slider] Incorrect CSS position on vertical slider indicator Feb 26, 2025
@mj12albert
Copy link
Member

Labelling this ready to take if anybody is interested in working on it

@oliviertassinari oliviertassinari changed the title [Slider] Incorrect CSS position on vertical slider indicator [slider] Incorrect CSS position on vertical slider indicator Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: slider This is the name of the generic UI component, not the React module! has workaround ready to take Help wanted. Guidance available. There is a high chance the change will be accepted
Projects
Status: Backlog
Development

No branches or pull requests

2 participants