Skip to content

Commit 14f21c5

Browse files
author
Nathaniel Saul
committed
change _dgm to dgm_ to abide by the sklearn style
1 parent adc0593 commit 14f21c5

File tree

1 file changed

+6
-6
lines changed

1 file changed

+6
-6
lines changed

ripser/ripser.py

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,8 @@ class Rips(BaseEstimator):
3030
3131
Attributes
3232
----------
33-
_dgm : list of ndarray, each shape (n_pairs, 2)
34-
After `transform`, _dgm contains computed persistence diagrams in
33+
dgm_ : list of ndarray, each shape (n_pairs, 2)
34+
After `transform`, dgm_ contains computed persistence diagrams in
3535
each dimension
3636
3737
Examples
@@ -55,7 +55,7 @@ def __init__(self, maxdim=1, thresh=-1, coeff=2):
5555
self.maxdim = maxdim
5656
self.thresh = thresh
5757
self.coeff = coeff
58-
self._dgm = None
58+
self.dgm_ = None
5959

6060
def transform(self, X, distance_matrix=False, metric='euclidean'):
6161
"""Compute persistence diagrams for X data array.
@@ -78,7 +78,7 @@ def transform(self, X, distance_matrix=False, metric='euclidean'):
7878
X = pairwise_distances(X, metric=metric)
7979

8080
dgm = self._compute_rips(X)
81-
self._dgm = dgm
81+
self.dgm_ = dgm
8282

8383
return dgm
8484

@@ -87,7 +87,7 @@ def fit_transform(self, X, distance_matrix=False, metric='euclidean'):
8787
8888
"""
8989
self.transform(X, distance_matrix, metric)
90-
return self._dgm
90+
return self.dgm_
9191

9292
def _compute_rips(self, dm):
9393
""" Compute the persistence diagram
@@ -126,7 +126,7 @@ def plot(self, diagram=None, diagonal=True, sz=20, labels='dgm', axcolor=np.arra
126126
""" Plot each diagram on the same plot.
127127
"""
128128
if diagram is None:
129-
diagram = self._dgm
129+
diagram = self.dgm_
130130

131131
if type(diagram) is not list:
132132
diagram = [diagram]

0 commit comments

Comments
 (0)