Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] Editing filter does not allow saving #1667

Open
spencerkoo opened this issue Mar 4, 2025 · 2 comments
Open

[bug] Editing filter does not allow saving #1667

spencerkoo opened this issue Mar 4, 2025 · 2 comments

Comments

@spencerkoo
Copy link

When editing a filter - particularly if is than one condition - sometimes does not allow the newly edited filter to be saved.

  • Check mark at the top right is unclickable and there is no way for the filter to be saved
  • I find this happens when I have more than one condition, and then I go back and edit
  • When I add the condition, the checkbox is unclickable, and I must 'x' out and start again by removing all filters
@spencerkoo spencerkoo changed the title Editing filter does not allow saving [bug] Editing filter does not allow saving Mar 4, 2025
@mtotschnig
Copy link
Owner

@spencerkoo Thanks for reporting. I am not able to reproduce yet. Is it possible to describe an exact scenario that reproducibly triggers the problem? The intended logic, is that the edit icon is only visible if there is a difference between the last applied set of criteria and the edited set. So for example if you edit a criterion and then edit it back to the same value it had before, the done icon would be greyed out. Are you sure, that this is not happening in your case?

@spencerkoo
Copy link
Author

spencerkoo commented Mar 5, 2025

@mtotschnig I tested this again, and it appears that the "Match all of the following" and "Match any of the following" does not register as a change.

So if you edit the filters and try to change form Match all to Match any, it it will not let you save that changed filter set.

To make it work, you must add a filter and then remove it or make another edit that registers as a change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants