Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow notify to run on a different path #232

Open
jmbrunskill opened this issue Nov 7, 2023 · 0 comments · May be fixed by #233
Open

Allow notify to run on a different path #232

jmbrunskill opened this issue Nov 7, 2023 · 0 comments · May be fixed by #233
Assignees
Labels
bug Something isn't working

Comments

@jmbrunskill
Copy link
Collaborator

Describe the bug

If we want to run notify behind a proxy server on a path such as /notify/ currently it doesn't work.

To Reproduce

Setup a server such as (caddy)[https://caddyserver.com/download]

Using a Caddyfile config like this...

:7007 {
        respond "This request didn't make it to notify, sorry"
        redir /notify /notify/
        handle_path /notify/* {
                reverse_proxy http://localhost:8007
        }
}

Steps to reproduce the behaviour:

  1. Start Caddy and notify (on default port 8007)
  2. go to http://localhost:7007/notify/
  3. Notify doesn't load

Expected behaviour

Should be able to run notify on this path (perhaps with a config change?)

Additional context

This stack overflow suggests using a public path
publicPath: '/app'
https://stackoverflow.com/questions/63674303/configure-webpack-to-serve-react-at-relative-path

Maybe we set it up to always run on /notify/?

@jmbrunskill jmbrunskill added the bug Something isn't working label Nov 7, 2023
@jmbrunskill jmbrunskill self-assigned this Nov 7, 2023
@jmbrunskill jmbrunskill linked a pull request Nov 8, 2023 that will close this issue
3 tasks
@jmbrunskill jmbrunskill linked a pull request Nov 8, 2023 that will close this issue
3 tasks
@lache-melvin lache-melvin self-assigned this Nov 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants