Skip to content

Commit 65286e6

Browse files
committed
ci: git-validation can go suck an egg
Signed-off-by: Miquel Sabaté Solà <[email protected]>
1 parent a1fcf17 commit 65286e6

File tree

3 files changed

+1
-33
lines changed

3 files changed

+1
-33
lines changed

.github/workflows/ci.yml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -40,12 +40,7 @@ jobs:
4040
with:
4141
version: ${{ matrix.emacs_version }}
4242

43-
- uses: actions/setup-go@v5
44-
4543
- uses: actions/checkout@v4
4644

47-
- name: Install git-validation
48-
run: go install github.com/vbatts/git-validation@latest
49-
5045
- name: make ci
5146
run: make ci

CONTRIBUTING.org

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -31,25 +31,6 @@ style. You can run these checkers by performing:
3131
$ make lint
3232
#+END_SRC
3333

34-
*** Git validation
35-
36-
In order to ensure that the git log is as maintainable as possible, the
37-
[[https://github.com/vbatts/git-validation][git-validation]] tool is used. You can install this tool by running:
38-
39-
#+BEGIN_SRC bash
40-
$ go get -u github.com/vbatts/git-validation
41-
#+END_SRC
42-
43-
If you already have this tool installed, then simply perform:
44-
45-
#+BEGIN_SRC bash
46-
$ make git-validation
47-
#+END_SRC
48-
49-
Note that if you don't have this tool installed the task will do nothing (it
50-
will just print a help message). This is done so when running the default make
51-
task this doesn't interrupt it.
52-
5334
*** Load test
5435

5536
In order to test that this theme can be actually loaded, run:

Makefile

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ $(OBJECTS): %.elc: %.el
3636
ci: version all
3737

3838
.PHONY: test
39-
test: lint git-validation checkdoc load-test
39+
test: lint checkdoc load-test
4040

4141
# Maybe it would've been nicer to use Cask or something like that, but it
4242
# doesn't have too many dependencies so it should be fine for now.
@@ -70,14 +70,6 @@ fix-stdlib-changes:
7070
lint: vendor fix-stdlib-changes
7171
@$(BATCH) -l elisp-lint.el -f elisp-lint-files-batch $(ELS)
7272

73-
.PHONY: git-validation
74-
git-validation:
75-
ifeq (, $(shell which git-validation 2> /dev/null))
76-
@echo "You don't have 'git-validation' installed, consider installing it (see the CONTRIBUTING.org file)."
77-
else
78-
@git-validation -q -range 7d38ca68163c..HEAD -travis-pr-only=false
79-
endif
80-
8173
.PHONY: load-test
8274
load-test:
8375
@$(BATCH) -nw --load soria-theme.el \

0 commit comments

Comments
 (0)