Skip to content

Commit 0bfa8fc

Browse files
valpackettbarni2000
authored andcommitted
squash! arm64: dts: qcom: msm8917: fix cpu idle states
pwrdn/ghds (4) is the only cluster state we can use. retention (2) seems broken (hangs), looks like that's why it was marked as worse than ghds in the downstream dts. Signed-off-by: Val Packett <val@packett.cool>
1 parent a774ba5 commit 0bfa8fc

File tree

1 file changed

+6
-19
lines changed

1 file changed

+6
-19
lines changed

arch/arm64/boot/dts/qcom/msm8917.dtsi

Lines changed: 6 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -113,26 +113,13 @@
113113
};
114114

115115
domain-idle-states {
116-
/* Seems strange, but downstream msm8917-pm.dtsi specifies
117-
GHDS as faster than retention, unlike for other SoCs */
118-
119-
cluster_gdhs: cluster-gdhs {
116+
cluster_pwrdn: cluster-sleep-0 {
120117
compatible = "domain-idle-state";
121-
idle-state-name = "cluster-gdhs";
118+
idle-state-name = "cluster-sleep-0";
122119
arm,psci-suspend-param = <0x41000043>;
123-
entry-latency-us = <150>;
120+
entry-latency-us = <240>;
124121
exit-latency-us = <280>;
125-
min-residency-us = <560>;
126-
local-timer-stop;
127-
};
128-
129-
cluster_ret: cluster-retention {
130-
compatible = "domain-idle-state";
131-
idle-state-name = "cluster-ret";
132-
arm,psci-suspend-param = <0x41000033>;
133-
entry-latency-us = <120>;
134-
exit-latency-us = <650>;
135-
min-residency-us = <1300>;
122+
min-residency-us = <6000>;
136123
local-timer-stop;
137124
};
138125
};
@@ -146,7 +133,7 @@
146133
arm,psci-suspend-param = <0x40000003>;
147134
entry-latency-us = <125>;
148135
exit-latency-us = <180>;
149-
min-residency-us = <595>;
136+
min-residency-us = <2000>;
150137
local-timer-stop;
151138
};
152139
};
@@ -204,7 +191,7 @@
204191

205192
cluster_pd: power-domain-cluster {
206193
#power-domain-cells = <0>;
207-
domain-idle-states = <&cluster_gdhs>, <&cluster_ret>;
194+
domain-idle-states = <&cluster_pwrdn>;
208195
};
209196

210197
cpu_pd0: power-domain-cpu0 {

0 commit comments

Comments
 (0)