Skip to content
This repository has been archived by the owner on Mar 18, 2023. It is now read-only.

Treeshaking breaks sprite build #120

Open
AndyOGo opened this issue Nov 14, 2016 · 3 comments
Open

Treeshaking breaks sprite build #120

AndyOGo opened this issue Nov 14, 2016 · 3 comments
Assignees
@mrsum

Comments

@AndyOGo
Copy link

AndyOGo commented Nov 14, 2016 •
edited
Loading

Using rollup-loader to utilize treeshaking removes all function marks like var __svg__, var __sprite__, etc.

Hence no sprites get generated.

I suppose to put this configs inside the webpack config itself, mapped by each entry points name.
@mrsum
Copy link
Owner

mrsum commented Nov 14, 2016

Is it [WIP] currently, right?

@AndyOGo
Copy link
Author

AndyOGo commented Nov 14, 2016

@mrsum
Yeah it is WIP, actuallyI'm not certain if it got abandoned in favour of webpack 2.

Anyway function marks will fail with treeshaking approach.

@mrsum
Copy link
Owner

mrsum commented Nov 14, 2016

@AndyOGo Okay, i will fix it ASAP.

@mrsum mrsum self-assigned this Nov 14, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mrsum mrsum

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AndyOGo @mrsum