Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ViewCell Analyzer for Xamarin.Forms #472

Open
mrlacey opened this issue May 8, 2021 · 0 comments
Open

Add ViewCell Analyzer for Xamarin.Forms #472

mrlacey opened this issue May 8, 2021 · 0 comments
Labels
enhancement A change or improvement to something that exists Xamain.Forms Relates to XAML in Xamarin.Forms projects XAML-Analysis Relates to XAML Analysis functionality
Milestone

Comments

@mrlacey
Copy link
Owner

mrlacey commented May 8, 2021

Don't put a ViewCell in a Carousel

https://docs.microsoft.com/en-us/xamarin/xamarin-forms/user-interface/carouselview/populate-data

When using CarouselView, never set the root element of your DataTemplate objects to a ViewCell. This will result in an exception being thrown because CarouselView has no concept of cells.

This is a follow-on from #411 but wasn't implemented there as doing so would mean adding this analysis for the Carousel.
Consider doing when can view parents/containers from within an analyzer.

Low priority due to low use of ViewCell

@mrlacey mrlacey added enhancement A change or improvement to something that exists XAML-Analysis Relates to XAML Analysis functionality Xamain.Forms Relates to XAML in Xamarin.Forms projects labels May 8, 2021
@mrlacey mrlacey added this to the Backlog milestone May 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A change or improvement to something that exists Xamain.Forms Relates to XAML in Xamarin.Forms projects XAML-Analysis Relates to XAML Analysis functionality
Projects
None yet
Development

No branches or pull requests

1 participant