implement configurable fetch interval

Author: mriehl

app/clients/ClientsModule.scala

@@ -12,12 +12,11 @@ trait ClientsModule {
   def wsClient: WSClient
 
   implicit def configuration: Configuration
+  def mandatoryPropertyMissing(path: String): Nothing
 
   implicit val executionContext: ExecutionContext
   implicit val materializer: Materializer
 
-  private def mandatoryPropertyMissing(path: String): Nothing = throw new UnconfiguredApplicationException(s"Missing mandatory property in application.conf: '$path'")
-
   lazy val carjumpBaseUrl: CarjumpBaseUrl = CarjumpBaseUrl(new URL(configuration.getString(carjumpUrlPath)
     .getOrElse(mandatoryPropertyMissing(carjumpUrlPath))))
 

app/jobs/CarjumpFetchInterval.scala

@@ -0,0 +1,5 @@
+package jobs
+
+import scala.concurrent.duration.FiniteDuration
+
+case class CarjumpFetchInterval(value: FiniteDuration) extends AnyVal

app/jobs/FetchingActor.scala

@@ -8,16 +8,16 @@ import scala.concurrent.duration.FiniteDuration
 import scala.concurrent.duration._
 import scala.util.control.NonFatal
 
-class FetchingActor(interval: FiniteDuration, apiService: CarjumpApiService) extends Actor with ActorLogging with FSM[FetchingActor.State, FetchingActor.Data] {
+class FetchingActor(interval: CarjumpFetchInterval, apiService: CarjumpApiService) extends Actor with ActorLogging with FSM[FetchingActor.State, FetchingActor.Data] {
   import FetchingActor._
   implicit val ec = context.dispatcher
 
   startWith(Stopped, Uninitialized)
 
   when(Stopped) {
     case Event(Start, _) ⇒
-      log.info("Fetching actor starting up..")
-      val scheduleHook = context.system.scheduler.schedule(1.seconds, interval)(self ! Fetch)
+      log.info(s"Fetching actor starting up, re-fetch every $interval")
+      val scheduleHook = context.system.scheduler.schedule(1.seconds, interval.value)(self ! Fetch)
       goto(Idle) using FetchData(scheduleHook, Seq.empty)
 
     case Event(CacheValue, _) ⇒

app/jobs/JobsModule.scala

@@ -18,11 +18,16 @@ trait JobsModule {
   implicit def configuration: Configuration
 
   implicit val materializer: Materializer
-
+  def mandatoryPropertyMissing(path: String): Nothing
   def carjumpClient: CarjumpClient
   def apiService: CarjumpApiService
-  import scala.concurrent.duration._
-  val duration = 30.seconds
+
+  lazy val fetchInterval: CarjumpFetchInterval = {
+    import scala.concurrent.duration._
+    val path = "carjump.fetchIntervalSeconds"
+    val fetchIntervalSeconds = configuration.getInt(path).getOrElse(mandatoryPropertyMissing(path))
+    CarjumpFetchInterval(fetchIntervalSeconds.seconds)
+  }
 
   lazy val jobsSupervisorActor = {
     def fetchingActor = wire[FetchingActor]

app/launch/CarjumpModule.scala

@@ -1,5 +1,6 @@
 package launch
 
+import clients.UnconfiguredApplicationException
 import scala.concurrent.{ ExecutionContext, Future, blocking }
 
 import clients.ClientsModule
@@ -17,6 +18,7 @@ trait CarjumpModule
     with ClientsModule
     with SLF4JLogging {
 
+  def mandatoryPropertyMissing(path: String): Nothing = throw new UnconfiguredApplicationException(s"Missing mandatory property in application.conf: '$path'")
   def configuration: Configuration
   def applicationLifecycle: ApplicationLifecycle
   override implicit val executionContext: ExecutionContext

conf/additional-application.conf

@@ -1,3 +1,4 @@
 carjump {
   url = "http://challenge.carjump.net"
+  fetchIntervalSeconds = 35
 }