Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spam #91

Open
greggman opened this issue Jan 6, 2024 · 14 comments
Open

Spam #91

greggman opened this issue Jan 6, 2024 · 14 comments

Comments

@greggman
Copy link
Contributor

greggman commented Jan 6, 2024

People suck! You try to do something nice and someone always and without fail shits all over you 馃槩

Screenshot 2024-01-05 at 16 07 09
@jfontan
Copy link
Collaborator

jfontan commented Jan 6, 2024

Thank you for the heads up. I'm trying to clean up.

@jfontan
Copy link
Collaborator

jfontan commented Jan 6, 2024

I believe I've cleaned up most of it. The service is up again.

@jfontan
Copy link
Collaborator

jfontan commented Jan 6, 2024

I'll close it tomorrow if I can't find any more entries like that.

@jfontan
Copy link
Collaborator

jfontan commented Jan 6, 2024

It happened again. I took down the page while I find time to clean up and add a check to somehow alleviate it. Today I believe I won't have time to do it.

@Skoopyy
Copy link

Skoopyy commented Jan 6, 2024

It happened again. I took down the page while I find time to clean up and add a check to somehow alleviate it. Today I believe I won't have time to do it.

What is this exploit exactly and how are you going to patch it?

Is there going to be an ETA on when the site is going to be back up?

@Memexurer
Copy link

so the exploit works by just spamming shader upload form (POST https://glslsandbox.com/e).
and i think the best way to fix this would be to add a captcha (cloudflare turnstile for example) to the shader upload form...

@Skoopyy
Copy link

Skoopyy commented Jan 6, 2024

so the exploit works by just spamming shader upload form (POST https://glslsandbox.com/e). and i think the best way to fix this would be to add a captcha (cloudflare turnstile for example) to the shader upload form...

good idea but is there any downsides to this?

@Memexurer
Copy link

good idea but is there any downsides to this?

i dont think so? you can read more about turnstile here: https://www.cloudflare.com/products/turnstile/

@jfontan
Copy link
Collaborator

jfontan commented Jan 7, 2024

@Skoopyy

It's strange that your user appears in the payload in some of the spammy effects:

VERY GOOD SHADER t.me/telegrosik - skoopyy on discord

@jfontan
Copy link
Collaborator

jfontan commented Jan 7, 2024

@Memexurer I would use captcha just as last resort. This adds friction to users and I prefer to find other ways before resorting to that.

Immediate things I plan to do:

  • Clean up the actual spam
  • Add a read only mode so people can access it but not upload new effects
  • Bring up the page with a notice saying that effects cannot be added or modified

The big problem is letting the clients create new effects without rate limit. This let the spammer generate 250k effects very fast.

I'm planning as first step adding a rate limit per client and give error if it is sending too many effects in a short time. I also plan to do the same when the payload is equal or similar but this will be done afterwards.

@mrdoob what do you think?

@Skoopyy
Copy link

Skoopyy commented Jan 8, 2024

@Skoopyy

It's strange that your user appears in the payload in some of the spammy effects:

VERY GOOD SHADER t.me/telegrosik - skoopyy on discord

Very strange indeed...

@mrdoob
Copy link
Owner

mrdoob commented Jan 8, 2024

@jfontan considering the nature of the site, maybe we could add Github Oauth?

@jfontan
Copy link
Collaborator

jfontan commented Jan 8, 2024

@jfontan considering the nature of the site, maybe we could add Github Oauth?

I'll take a look at how this can be implemented.

@mrdoob
Copy link
Owner

mrdoob commented Jan 8, 2024

The underlying idea being that if we save the user for each effect, we could potentially report the spammy users to Github so they get banned 馃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants