Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chat Heads icons disappear - 204.6.4 #163

Closed
nco2k opened this issue Apr 27, 2024 · 4 comments
Closed

Chat Heads icons disappear - 204.6.4 #163

nco2k opened this issue Apr 27, 2024 · 4 comments
Labels
bug Something isn't working or is broken/crashing compatibility Involves an issue with another mod out of my control Caused by another mod/dependency/library

Comments

@nco2k
Copy link

nco2k commented Apr 27, 2024

Description

Chat Heads icons disappear when searching / matching a string.

How to reproduce

search for a string that matches.

Expected result

the icons shouldnt disappear.

Specs and Details

  • fabric-api-0.97.0+1.20.4.jar
  • chat_heads-0.10.32-fabric-1.20.3.jar
  • chatpatches-204.6.4.jar
  • YetAnotherConfigLib-3.4.1+1.20.4-fabric.jar
  • modmenu-9.2.0-beta.2.jar (725.53 KiB) Primary

Chat

@nco2k nco2k added the bug Something isn't working or is broken/crashing label Apr 27, 2024
@mrbuilder1961
Copy link
Owner

please edit this and replace everything with the filled out bug report template, that's what it's for.

@mrbuilder1961 mrbuilder1961 added awaiting info Further information is required (from the author, usually) and removed awaiting info Further information is required (from the author, usually) labels Apr 27, 2024
@mrbuilder1961 mrbuilder1961 changed the title Chat Heads icons disappear Chat Heads icons disappear - 204.6.4 May 10, 2024
@mrbuilder1961
Copy link
Owner

i'm not sure how easy of a fix this will be, considering chat heads has its own methods to determine which messages are sent by who, and i'm assuming the reason it breaks is because those methods get messed up when the messages are removed.

however, when you search, the way it works is it removes the visible lines associated with messages that don't match the search query, so it can put them back when you're done searching. so that temporary de-sync might mess with it too.

@dzwdz, what do you think? let me know either how heads are placed so i can accomodate, or maybe tell me what you would need to adjust. thanks!

@mrbuilder1961 mrbuilder1961 added the compatibility Involves an issue with another mod label Aug 9, 2024
@mrbuilder1961
Copy link
Owner

more info noted in chat_heads#95

@mrbuilder1961
Copy link
Owner

more info noted in chat_heads#95

there used to be more important notes in some issue, i think chat_heads#83 (that's what's linked in the other one), but it leads to a 404, so i guess they deleted the issue?

i'm going to take that, combined with the original reference being closed, as a signal they don't want to / can't / aren't willing to fix this issue with me. if any new info or related issues come up, please comment them here. in the meantime, i'll close this as incomplete.

@mrbuilder1961 mrbuilder1961 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 19, 2024
@mrbuilder1961 mrbuilder1961 added the out of my control Caused by another mod/dependency/library label Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working or is broken/crashing compatibility Involves an issue with another mod out of my control Caused by another mod/dependency/library
Projects
None yet
Development

No branches or pull requests

2 participants