Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nitpick: Literal newline in fabric.mod.json - 204.6.4 for 1.20.4 #159

Closed
YoshiRulz opened this issue Apr 12, 2024 · 4 comments
Closed

Nitpick: Literal newline in fabric.mod.json - 204.6.4 for 1.20.4 #159

YoshiRulz opened this issue Apr 12, 2024 · 4 comments
Labels
bug Something isn't working or is broken/crashing unsynced Could be/is fixed in another release; speculative

Comments

@YoshiRulz
Copy link

This doesn't seem to be a problem for the Fabric loader, but a strict parser like jq's will choke on literal newlines in strings.
Since it's not literal in the source:

"description": "A versatile client-side chat mod that makes the chat more useful and customizable! Check out the config and the GitHub page for more info!\nJoin the Discord at https://discord.gg/3MqBvNEyMz!",

...I'm guessing the process of expanding templates is what introduces it.

@YoshiRulz YoshiRulz added the bug Something isn't working or is broken/crashing label Apr 12, 2024
@mrbuilder1961
Copy link
Owner

Are you suggesting i escape it or just remove it?

@YoshiRulz
Copy link
Author

It is already escaped and something is "unescaping" it.

@mrbuilder1961
Copy link
Owner

closed in upcoming release 210.6.6 for 1.21, will be for 1.20.4 in the future!

@mrbuilder1961 mrbuilder1961 added unsynced Could be/is fixed in another release; speculative unpublished Fixed in a bleeding edge commit build, full release not published yet labels Aug 9, 2024
@YoshiRulz
Copy link
Author

Ah I neglected to tell you about my discovery: The cause of this is a missing escapeBackslash = true in the build script, see https://github.com/FabricMC/fabric-example-mod/pull/282/files.

@mrbuilder1961 mrbuilder1961 removed unpublished Fixed in a bleeding edge commit build, full release not published yet labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working or is broken/crashing unsynced Could be/is fixed in another release; speculative
Projects
None yet
Development

No branches or pull requests

2 participants