-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Xaero's Minimap Waypoint Sharing Messages are Blank (v204.6.4-1.20.4 Fabric) #158
Comments
In hindsight, this issue is pretty similar to #156. I should've looked better before creating the issue, I just searched for Xaero and saw nothing so I thought it would be okay. Apologies! |
no it's okay, this likely has a slightly different root cause that just happens to be causing the same outcome. i'll try and provide a different test build later to see what's up, but it seems like the xaero chat message is being marked as a vanilla-formatted one, which breaks the existing code bc it isn't actually formatted that way. i'll see what i can do! also, tysm for the detailed report! it's so organized and it almost makes me want to keep it up lmao |
i doubt this will fix the issue, but if you could try loading this and sending the log that would be great! just make sure to try and reproduce the issue again before sending the log. https://cdn.discordapp.com/attachments/901476441080860672/1229197816513958008/chatpatches-204.6.5.jar?ex=662eceac&is=661c59ac&hm=4c4437fd2aef22968873f7e6e257bd35c9f66574f5070dfa0e983ae5c4db8d0c& |
I'm also having the same issue, so I tried with that build you linked. Still not fixed. |
I have a similar issue where messages from a Discord integration mod don't have their "From Discord" prefix anymore, and appear as normal player messages instead. I think it's caused by the same source, most likely something to do with player name or text formatting. I would like to use this mod, but these issues are preventing me from doing so. |
which mod specifically? do you have a log link? |
I think it's this mod |
I tried this in singleplayer and got the same result. Here is the log https://mclo.gs/zSgUSUn |
could someone try reproducing this on the latest version again? preferably in singleplayer, but any type is fine. please attach a mclogs link too! thanks |
fixed in my testing, plz confirm with the not -dev jar here: https://github.com/mrbuilder1961/ChatPatches/actions/runs/10970016503/artifacts/1961132983 |
Description
When someone shares a waypoint using Xaero's Minimap, normally it's supposed to display a custom chat message with an add button. The minimap mod accomplishes this with intercepting messages that begin with "xaero-waypoint:" and replacing it with its custom message. However, with Chat Patches, the message will just show up as blank space.
How to reproduce
Expected result
The chat message should say the waypoint's name, and have an [Add] button that adds the waypoint.
Log file link
Specs and Details
Additional context
Thanks!
The text was updated successfully, but these errors were encountered: