Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't display video in screen cutouts #862

Open
zhengqwe opened this issue Feb 5, 2024 · 6 comments
Open

Don't display video in screen cutouts #862

zhengqwe opened this issue Feb 5, 2024 · 6 comments

Comments

@zhengqwe
Copy link

zhengqwe commented Feb 5, 2024

Add an option to control whether to display the video in the screen cutout. This will be useful for non-full screen devices.

@sfan5
Copy link
Member

sfan5 commented Feb 6, 2024

Can you give an example of "non-full screen devices"?

@zhengqwe
Copy link
Author

zhengqwe commented Feb 7, 2024

Can you give an example of "non-full screen devices"?

I mean a lot of phones have some component at the top of the screen (like the front camera), in some cases the video image is obscured by them. Cases where components are present on the screen are non-full-screen(The screen is not a complete block). My first language is not English, sorry.

@sfan5
Copy link
Member

sfan5 commented Feb 8, 2024

So you just mean normal devices with a cutout. I see.
I have a phone with a cutout myself and I don't mind the fullscreen playback (though the phone aspect ratio is wider than most video content anyway).
mpv-android used to have an option to not display in cutouts but I removed it a while ago due to implementation issues and because I wondered about if anyone was using it.

Not sure what to make of this.

@zhengqwe
Copy link
Author

zhengqwe commented Feb 9, 2024

Not sure what to make of this.

bring back the Extend video into the notch/cutout area feature and enable it default.

@4lex4
Copy link

4lex4 commented Mar 5, 2024

@sfan5

I wondered about if anyone was using it.

Are you kidding? Of course we use that, some devices have the big notch. mpv was great before you removed it for no reason, even vlc added the feature some time ago. It is a mandatory feature for any player on android just not requiring a discussion.

@sfan5
Copy link
Member

sfan5 commented Mar 5, 2024

As mentioned, it was not removed for no reason.
You are welcome to have a try at implementing this feature. Here is the old commit and here is Google's documentation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants