Ui file convert issue.

[BoubQC]

Hey guys, think I found an issue with the convert method.

line = line.replace("QtWidgets.QApplication.translate", "Qt.QtCompat.translate")

the import after the conversion will look like this:

from Qt import QtCore, QtGui, QtWidgets

So Qt is not imported. Should have an 'import Qt' somewhere or 'from Qt import QtCompat'.

[mottosso]

Thanks for your input @BoubQC! That does sound like a bug.

If you've got an idea how to solve it, it would be great to hear about it. Spontaneously, I think I'd do something along the lines of this:

line.replace("from PySide2 import", "from Qt import QtCompat, ")

And in that way, QtCompat would be imported in every case. I can't see any immediate problems with it, but I'd be interested in hearing your thoughts.

[BoubQC]

@mottosso Your solution looks fine to me. Adding a line 'import Qt' won't look any better and personally it's not a big deal to have an unused import in those files. You could validate if we need it before adding it but it's not essential.

By the way, would it be a good idea to add a line to replace 'from Pyside import'? For old files compiled with Pyside?

Thanks for your time