Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arguably, this library is too fragile #5

Open
timhunt opened this issue Jan 20, 2022 · 0 comments
Open

Arguably, this library is too fragile #5

timhunt opened this issue Jan 20, 2022 · 0 comments

Comments

@timhunt
Copy link
Contributor

timhunt commented Jan 20, 2022

Looking at the recent bug fixes, it seems that the way this library works, if anything goes wrong, it causes a fatal error, so you get no CSS at all.

A better strategy might be: Wrap the processing of each rule in a try-catch, and if there is an error, then just leave that rule alone (perhaps insert a CSS comment flagging the problem so it can be debugged - and Moodle coudl scan for those comments, and report them, before minifying the CSS).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant