Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vararg parameters are missing from the docs #397

Open
mairaw opened this issue Dec 15, 2018 · 1 comment
Open

vararg parameters are missing from the docs #397

mairaw opened this issue Dec 15, 2018 · 1 comment

Comments

@mairaw
Copy link

mairaw commented Dec 15, 2018

This is an example of a method with a vararg param:
https://docs.microsoft.com/en-us/dotnet/api/system.console.write?view=netframework-4.8#System_Console_Write_System_String_System_Object_System_Object_System_Object_System_Object_
I don't know how many we had of these.

On MSDN, a ... param was added to the bottom of the list
image

And had special syntax for those:
image

image

You can see they look different on ildasm:
image

/cc @joelmartinez @dend

@joelmartinez
Copy link
Member

interesting ... ok, so digging into this a bit, it looks like we'll need to take the CallingConvention into consideration, something which mdoc doesn't currently do, as you can see below, the calling convention for this particular method in question is VarArg:

image

@dend, is the calling convention something that we should start tracking as a separate property on the model?

Aside from (possibly) adding the property/value to the model ... the formatters will need to take this into account when formatting parameter lists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants