Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the MissionBoardRewardOptions enum back in #571

Open
Lenni009 opened this issue Aug 31, 2023 · 2 comments
Open

Add the MissionBoardRewardOptions enum back in #571

Lenni009 opened this issue Aug 31, 2023 · 2 comments

Comments

@Lenni009
Copy link

Is your feature request related to a problem? Please describe.
In 4.40, HG removed the MissionBoardRewardOptions enum, so we have no clear way of knowing what each array item means. This specifically affects the DEFAULTREALITY.MBIN file, where this array is used.

Describe the solution you'd like
Hardcode the enum members back in, like we have done with other enums as well.

Additional context
Needs verification whether the array members actually correspond to the names we want to give them.

Here's a diff between 4.38 (left) and 4.43 (right) DEFAULTREALITY.EXML:
diff 4.38 vs 4.43

@monkeyman192
Copy link
Owner

For context, the reason they were removed is because the enum we hard-coded to be associated with this array became a few elements bigger, and so no longer was able to be used with the array due to the size mismatch.

@Babscoole
Copy link

So, could be added back in, BUT, oldschool style, would need to test what each enum element now does/changes, in order to hardcode labels back in for them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants