Skip to content

Commit c7e190c

Browse files
committed
VK review
1 parent 04e5bff commit c7e190c

1 file changed

Lines changed: 6 additions & 4 deletions

File tree

source/client-backpressure/client-backpressure.md

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,8 @@ rules:
123123
1. The error is a retryable overload error.
124124
2. We have not reached `MAX_RETRIES`.
125125
- The default value of `MAX_RETRIES` is 2. Drivers MUST expose `maxAdaptiveRetries` as a configurable option for
126-
this maximum.
126+
this maximum. In the future, this default value or the default behavior of the driver may change without being
127+
considered a breaking change.
127128
- This intentionally changes the behavior of CSOT which otherwise would retry an unlimited number of times within
128129
the timeout to avoid retry storms.
129130
3. (CSOT-only): There is still time for a retry attempt according to the
@@ -403,9 +404,10 @@ The selection of 2 as a default attempts to broadly pick a sensible default for
403404
benefit rather than a negative during overload. However, savvy users, the users expected to be most affected by overload
404405
and have the most insight into the specifics of their workload and cluster, will likely find that tweaking this value on
405406
a per-workload basis produces better results. Additionally, there are situations where disabling overload retries
406-
entirely is optimal. Without a knob, those situations will cause users to either have a strictly worse experience with a
407-
new driver, or force them to downgrade to an older driver to avoid the issue. These are two strong motivations to add a
408-
knob for `maxAdaptiveRetries`.
407+
entirely is optimal, such as non-critical workloads against a cluster shared with critical workloads. Without a knob,
408+
those situations will cause users to either have a strictly worse experience with a new driver, or force them to
409+
downgrade to an older driver to avoid the issue. These are two strong motivations to add a knob for
410+
`maxAdaptiveRetries`.
409411

410412
### Why make `enableOverloadRetargeting` configurable?
411413

0 commit comments

Comments
 (0)