-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(NODE-6057): implement CursorResponse for lazy document parsing #4085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nbbeeken
force-pushed
the
chore-cursor-v2-final
branch
2 times, most recently
from
April 18, 2024 19:42
98a105b
to
a537db1
Compare
nbbeeken
commented
Apr 19, 2024
nbbeeken
commented
Apr 19, 2024
nbbeeken
commented
Apr 19, 2024
nbbeeken
commented
Apr 19, 2024
nbbeeken
commented
Apr 19, 2024
nbbeeken
commented
Apr 19, 2024
nbbeeken
commented
Apr 19, 2024
nbbeeken
commented
Apr 19, 2024
nbbeeken
commented
Apr 19, 2024
baileympearson
added
the
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
label
Apr 19, 2024
addaleax
reviewed
Apr 22, 2024
…ror in changestream prose test
nbbeeken
force-pushed
the
chore-cursor-v2-final
branch
from
April 25, 2024 17:22
70df234
to
ca88168
Compare
baileympearson
requested changes
Apr 29, 2024
baileympearson
approved these changes
May 1, 2024
baileympearson
approved these changes
May 1, 2024
baileympearson
added
Team Review
Needs review from team
and removed
Primary Review
In Review with primary reviewer, not yet ready for team's eyes
labels
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is changing?
CursorResponse
subclass of MongoDBResponseIs there new documentation needed for these changes?
TBD. Is this something we want to apply to all cursors? Should we progressively migrate to this?
What is the motivation for this change?
An attempt at increasing performance. A sucessful decoupling of driver BSON and user BSON settings.
Only for FindCursor, BSON documents from the current batch are now parsed on each iteration.
One clear improvement is that any cursor that is closed before exhaustion will take significantly less run time.
Release Highlight
Fill in title or leave empty for no highlight
Double check the following
npm run check:lint
scripttype(NODE-xxxx)[!]: description
feat(NODE-1234)!: rewriting everything in coffeescript