New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return iterator from all_by_all_pairwise_similarity() #67

Open

justaddcoffee opened this issue Jun 13, 2023 · 0 comments

Member

justaddcoffee commented Jun 13, 2023

Right now we are returning all results:

semsimian/src/lib.rs

Line 90 in 11fff68

pub fn all_by_all_pairwise_similarity(

like so in Oak, but it would probably be way more efficient to return an iterator instead:

These docs/stack overflow resources imply it's pretty straightforward:
https://pyo3.rs/main/doc/pyo3/types/struct.pyiterator
https://stackoverflow.com/questions/75459915/how-do-i-return-rust-iterator-from-a-python-module-function-using-pyo3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment