Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop if custom IC map does not parse as expected #127

Open
caufieldjh opened this issue May 13, 2024 · 0 comments · May be fixed by #128
Open

Stop if custom IC map does not parse as expected #127

caufieldjh opened this issue May 13, 2024 · 0 comments · May be fixed by #128

Comments

@caufieldjh
Copy link
Member

Right now, if an error is encountered when loading a custom IC map, it raises an error:

Loading custom IC map from: "test_ic.tsv"
Failed to import custom IC map: Line does not contain enough columns

See

semsimian/src/lib.rs

Lines 118 to 129 in e2cba82

if let Some(custom_ic_map_path) = custom_ic_map_path {
let path = PathBuf::from(custom_ic_map_path);
println!("Loading custom IC map from: {:?}", path);
match import_custom_ic_map(&path) {
Ok(ic_map) => {
println!("Custom IC map imported successfully.");
imported_ic_map.insert(predicate_set_to_key(&Some(predicates.clone())), ic_map);
}
Err(e) => eprintln!("Failed to import custom IC map: {}", e),
}
}

This should probably end the process before it continues on to build a new IC map, as the user may not notice this error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant