Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create a set of unit/integration tests that can used in semsimian and also Monarch App #118

Open
justaddcoffee opened this issue Feb 14, 2024 · 4 comments

Comments

@justaddcoffee
Copy link
Member

Per convo in A&A Monarch Huddle on Feb 13, 2024

@cmungall says: we should have a bank of test profiles (e.g. tracked in yaml in github) with annotations of what we expect the results to be. Test the framework with this. The UI group can just use the same set

@hrshdhgd can you comment about whether our current semsimian tests can be shared with the Monarch App/UI team via a set of YAML files or some such?

@justaddcoffee
Copy link
Member Author

also @kevinschaper thoughts on this? would this be useful, and where would the test artifacts (YAML or otherwise) live?

@justaddcoffee justaddcoffee changed the title create a set of unit/integration tests that can used in semsimian and also Monarch App search/compare create a set of unit/integration tests that can used in semsimian and also Monarch App Feb 14, 2024
@cmungall
Copy link
Member

cmungall commented Feb 14, 2024 via email

@justaddcoffee
Copy link
Member Author

justaddcoffee commented Feb 14, 2024

Per discussion today on the MWF hackathon, could we refine/clarify here what this test suite should be testing, and what the intention is

If we are testing that semsimian and the Monarch App are getting the correct semantic similarity results given some simple test fixtures, then it seems like this suite belongs in semsimian, and possibly the existing semsimian tests are sufficient.

Possibly though this ticket is about testing edge cases that we observed in the Monarch App when doing an association search: e.g. pairs of terms with fairly generic most informative common ancestors like "Abnormality of the Head" were showing fairly high IC scores. This kind of testing possibly is more to do with the data itself (Phenio) or how we are generating frequencies?

What sorts of things do we want to test here?

@caufieldjh
Copy link
Member

See also monarch-initiative/phenio#58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants