Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repo for ODK changes; produce relation graph #31

Merged
merged 5 commits into from
May 25, 2023
Merged

Conversation

caufieldjh
Copy link
Member

@caufieldjh caufieldjh commented Jan 4, 2023

  • Repository updates
  • More stringent prefix filtering
  • Produce relation_graph output along with other artifacts

@caufieldjh
Copy link
Member Author

The last item is really a non-issue: producing the RG output depends upon making phenio.owl, so the Makefile goal of relation_graph will produce both.

@caufieldjh caufieldjh linked an issue Jan 4, 2023 that may be closed by this pull request
Copy link
Member

@matentzn matentzn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was committing all these site files intentional?

@caufieldjh
Copy link
Member Author

Was committing all these site files intentional?

Nope, that should have gone on the gh-pages branch

@caufieldjh
Copy link
Member Author

This is the set of all CURIE prefixes entering KG-Phenio (i.e., some, like HGNC prefixes, get processed further for normalization. These are the immediate result of transforming to KGX TSV):

APO
BFO
biolink
BSPO
BTO
CARO
CHEBI
CHR
CIO
CL
CLO
dcat
dcterms
dctypes
DDANAT
DOID
ECO
EMAPA
ENVO
faldo
FAO
FBbt
FBcv
FlyBase
FMA
foaf
FOODON
FYPO
GENO
GO
HP
IAO
MA
MF
MFOMD
MI
MONDO
MP
MPATH
NBO
NCBITaxon
NCIT
OBA
OBAN
OBI
OBO
OGMS
OIO
OMIM
Orphanet
owl
PATO
pav
PCO
PO
PR
PW
rdf
rdfs
RO
RXCUI
SEPIO
SIO
skos
SO
STATO
TO
UBERON
UMLS
UPHENO
WBBT
WBbt
WBPhenotype
XAO
XCO
ZFA
ZFS
ZP

In the following cases, the prefixes only exist as categories, likely from merging Biolink or retaining xrefs. They don't contribute any meaningful nodes to the eventual graph, or they only contribute one. Even so, they shouldn't be retained if they aren't serving a purpose in PHENIO.

APO
BTO
CARO
CHR
CIO
CLO
DDANAT
DOID
OMIM
RXCUI
TO
UMLS
pav

OMIM definitely shouldn't be in there.

@caufieldjh
Copy link
Member Author

Want to merge this PR so I can start new ones without this getting too stale - prefix filtering will go in new PR, while other repo updates will go in different PR(s)

@caufieldjh caufieldjh changed the title Stringency for filtering Update repo for ODK changes; produce relation graph May 25, 2023
@caufieldjh caufieldjh marked this pull request as ready for review May 25, 2023 19:21
@caufieldjh caufieldjh merged commit a353346 into main May 25, 2023
@caufieldjh caufieldjh deleted the stringency branch May 25, 2023 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use more stringent prefix filtering
2 participants