Skip to content

stnl is missing node results #1611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aquapi opened this issue Jan 30, 2025 · 7 comments · Fixed by #1612
Closed

stnl is missing node results #1611

aquapi opened this issue Jan 30, 2025 · 7 comments · Fixed by #1612

Comments

@aquapi
Copy link
Contributor

aquapi commented Jan 30, 2025

@hoeck Did anything happened to stnl on Node that the results were not displayed

Image

@DarkGL
Copy link
Collaborator

DarkGL commented Jan 30, 2025

Maybe because of this

#1608 (comment)

@aquapi
Copy link
Contributor Author

aquapi commented Jan 30, 2025

No I run it locally and it works fine

@aquapi
Copy link
Contributor Author

aquapi commented Jan 31, 2025

@DarkGL

Image

@hoeck
Copy link
Collaborator

hoeck commented Jan 31, 2025

@aquapi the stnl benchmark fails to run on node16: https://github.com/moltar/typescript-runtime-type-benchmarks/actions/runs/13053425402/job/36418580598#step:9:674

Looks like ts-node does not like ESM modules and your compiler generates them for its JIT code?

We need to fix this as no benchmarks are being updated atm. That action fails all the time.

@hoeck
Copy link
Collaborator

hoeck commented Jan 31, 2025

Just tried to run the stnl benchmark myself: it only works on node 23, versions below seem to fail (tested 22, 20 and 16).

I guess a quick fix (without dropping the stnl benchmark) would be to ignore any errors while running the benchmarks and only include results for libraries that ran without errors.

That would also give a nice indication of the node versions supported by a library 😁.

The long term solution would be to have better isolated benchmarks and not relying on ts-node any more.

I'll create a PR for everyone to have a look at.

@aquapi
Copy link
Contributor Author

aquapi commented Jan 31, 2025

@hoeck Have u tried using tsx instead of ts-node
It doesn't seem to have these module issues

@hoeck
Copy link
Collaborator

hoeck commented Jan 31, 2025

@aquapi Just tried it, that doesn't work as a drop-in replacement for ts-node. I get import errors for the benchmark files. Does it work for you?

The big is actually to isolate all benchmark modules: #899

I expect to get more module and environment (tsconfig, individual build steps ...) issues with the current single package global orchestration approach.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants