-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
isolate benchmarked module dependencies #1219
Comments
Yes, 100% the issue is there and needs to be fixed. I wanted to re-design the entire project setup entirely, including this problem if isolation and the umbrella issue is #899, albeit it does not have the meat on that bone there, regarding the details. I will link to this issue from there for documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Having all tested modules share the same node_modules namespace seems to introduce new issues / limits:
The first issue may just be a nuisance, requiring more maintenance work.
The second one though may be more severe, in the worst case requiring us to drop old modules or to wait until all modules are able to use new TS versions.
In #864 we already moved to running each benchmark in its own process. Might be just the next logical step to also isolate node_modules? That also helps isolating the different build / code generation steps required for some modules.
@moltar any feedback?
The text was updated successfully, but these errors were encountered: