-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert tests to using subtests #1520
Comments
And you don't have to convert all tests at once, one PR per test file should be fine. |
We've converted promise.t in its entirety first, so there is an example for what's expected. |
And cgi.t has been converted so there's an example for a test with lite app. |
Since we keep linking to the issue, it is probably worth mentioning that all new code should always use subtests. Even if the test file it is added to has not been converted yet. |
Convert to using subtests per issue #1520
Convert to using subtests per issue #1520
Not a particularly hard task, but converting all tests is a lot of work. We want to go from:
to:
Block comments become the subtest description, and then we add a blank line in between unrelated test cases within the subtest. Here is another example.
The text was updated successfully, but these errors were encountered: