Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typings for width and height props #295

Open
sleepyArpan opened this issue Sep 11, 2023 · 2 comments
Open

Typings for width and height props #295

sleepyArpan opened this issue Sep 11, 2023 · 2 comments

Comments

@sleepyArpan
Copy link

Hey, I just ran into an issue with the typings of height and width. I want to give both these values as inherit but ts errors out saying that it only expects numbers in this case. Is this intended?
@mohitk05
Copy link
Owner

Hey, thanks for raising the issue. Are you interested in solving it as well?

@sleepyArpan
Copy link
Author

yes will raise a PR, just to be clear adding the type string would be enough I assume?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mohitk05 @sleepyArpan