backend-refactor-61-repo_package_cleaner_convention #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
standard-librarian
commented
Apr 13, 2023
•
standard-librarian
commented
…- (prefix) from interfaces
standard-librarian
changed the title
mohamed-sallam
requested changes
Apr 14, 2023
| @@ -46,13 +46,13 @@ | |||
| * @author Mohamed Sallam | |||
| */ | |||
| public class LockService extends Service { | |||
| private final DetoxPeriodRepository detoxPeriodRepository; | |||
| private final DetoxPeriodRepositoryImpl detoxPeriodRepository; | |||
There was a problem hiding this comment.
Suggested change
| private final DetoxPeriodRepositoryImpl detoxPeriodRepository; | |
| private final DetoxPeriodRepository detoxPeriodRepository; |
I think this the use of the interface.
Don't forget to import its lib.
Comment on lines
+31
to
+33
| private DeviceRepositoryImpl deviceRepository; | ||
| private GroupRepositoryImpl groupRepository; | ||
| private DetoxPeriodRepositoryImpl detoxPeriodRepository; |
There was a problem hiding this comment.
Suggested change
| private DeviceRepositoryImpl deviceRepository; | |
| private GroupRepositoryImpl groupRepository; | |
| private DetoxPeriodRepositoryImpl detoxPeriodRepository; | |
| private DeviceRepository deviceRepository; | |
| private GroupRepositoryI groupRepository; | |
| private DetoxPeriodRepository detoxPeriodRepository; |
The same as before.
| @@ -33,7 +33,7 @@ | |||
| * @author Mohamed Sallam | |||
| */ | |||
| public class UpdateGroupViewModel extends AndroidViewModel { | |||
| private final GroupRepository groupRepository; | |||
| private final GroupRepositoryImpl groupRepository; | |||
There was a problem hiding this comment.
Suggested change
| private final GroupRepositoryImpl groupRepository; | |
| private final GroupRepository groupRepository; |
The same as before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.