Avoid the tank to ever become completely empty - fixes #4526 #4527
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casella
requested review from
HansOlsson,
hubertus65 and
arunkumar-narasimhan
arunkumar-narasimhan
approved these changes
Feb 11, 2025
HansOlsson
reviewed
Feb 11, 2025
As discussed at the meeting
beutlich
reviewed
Feb 12, 2025
Removed explicit reference to value in assert string Co-authored-by: Thomas Beutlich <[email protected]>
|
Waiting for one more review to be merged and back-ported to maint/4.1.0 |
Esther-Devakirubai
pushed a commit
that referenced
this pull request
Feb 25, 2025
* Avoid the tank to ever become completely empty * Update Modelica/Fluid/Vessels.mo As discussed at the meeting * Update Modelica/Fluid/Vessels.mo Removed explicit reference to value in assert string Co-authored-by: Thomas Beutlich <[email protected]> --------- Co-authored-by: Hans Olsson <[email protected]> Co-authored-by: Thomas Beutlich <[email protected]>
|
Backporting by #4545 |
casella
added a commit
that referenced
this pull request
Feb 25, 2025
…4545) * Avoid the tank to ever become completely empty * Update Modelica/Fluid/Vessels.mo As discussed at the meeting * Update Modelica/Fluid/Vessels.mo Removed explicit reference to value in assert string --------- Co-authored-by: Francesco Casella <[email protected]> Co-authored-by: Hans Olsson <[email protected]> Co-authored-by: Thomas Beutlich <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #4526 by:
With the following prescribed incoming flow (which is unchanged w.r.t. MSL 4.0.0)
OMC can now simulate the system successfully and produces the following transient for the level
As expected, the tank starts near empty at 1 mm level and the check-valve behaviour on the bottom port prevents the fluid from going down the drain. When providing 40 kg/s of incoming flow rate ,which is more than the out-going pipe can drain, the level goes up; however, when that flow rate is reduced to 10 kg/s, the level goes down, until it settles to a value very close to the level of the outlet port, which swallows the incoming flow while keeping the level constant. When the flow rate is reduced to zero, the level settles down to 1 mm, i.e., the port level. And so on and so forth...
As expected, since the tank fluid is initialized at ambient temperature and the fed fluid is also at ambient temperature, the fluid temperature is always well defined and always equal to ambient temperature, i.e., 20 degC
