Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move min(x,y) and max(x,y) definition out of array functions #3650

Open
pierre-haessig opened this issue Feb 12, 2025 · 1 comment · May be fixed by #3651
Open

Move min(x,y) and max(x,y) definition out of array functions #3650

pierre-haessig opened this issue Feb 12, 2025 · 1 comment · May be fixed by #3651

Comments

@pierre-haessig
Copy link

In the present (3.7dev) Modelica spec, the min(x,y) and max(x,y) for two scalars are defined within the array reduction functions (10.3.4 Reduction Functions and Operators).

I suggest to move them to the 3.7.1 Numeric Functions and Conversion Operators, along abs(v), because I believe they are of similar nature (I was looking for them, and it took me a while to find them in Ch 10)

Also, this change would consolidate the event generating status of min and max, which is discussed at the start of 10.3.4, but is also more in the topic of 3.7.1–3.7.2.

@HansOlsson
Copy link
Collaborator

I agree that it is odd that they are missing in 3.7.1, but I also find it logical that all variants of min and max are listed together.

With the new tables at the start I think it makes more sense to have them duplicated instead of moving them.

HansOlsson added a commit to HansOlsson/ModelicaSpecification that referenced this issue Feb 13, 2025
@HansOlsson HansOlsson linked a pull request Feb 13, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants