-
Notifications
You must be signed in to change notification settings - Fork 18.6k
-
Notifications
You must be signed in to change notification settings - Fork 18.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document healthcheck kill process / method at timeout #45927
Labels
area/docs
exp/beginner
kind/enhancement
Enhancements are not bugs or new features but can improve usability or performance.
Comments
rrauenza
added
kind/feature
Functionality or other elements that the project doesn't currently have. Features are new and shiny
status/0-triage
labels
Jul 11, 2023
Yes #43739 changed the code to send a |
thaJeztah
added
kind/enhancement
Enhancements are not bugs or new features but can improve usability or performance.
area/docs
exp/beginner
and removed
kind/feature
Functionality or other elements that the project doesn't currently have. Features are new and shiny
status/0-triage
labels
Jul 11, 2023
I actually prefer that for that exact reason! Thank you for the clarification. |
bpascard
added a commit
to bpascard/buildkit
that referenced
this issue
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
area/docs
exp/beginner
kind/enhancement
Enhancements are not bugs or new features but can improve usability or performance.
Description
There's an older issue that implies that the healthcheck command is killed with a SIGTERM and then a SIGKILL. This seems no longer true, though, from my testing and from reading the most recent code (if I have the right section of code...) -- it seems to go straight to SIGKILL, although I don't understand all of it. It might still wait for verification?
Could we document the kill method? As a contract to the user? I've googled around for it and have not been able to find any documentation on what happens. It would be nice to have it as a documented item for predictable behavior (and tracked in the future if the behavior needs to be changed.)
The text was updated successfully, but these errors were encountered: