Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mobx-devtools-mst peer dependency for MobX #110

Open
pm7y opened this issue May 17, 2022 · 3 comments
Open

Fix mobx-devtools-mst peer dependency for MobX #110

pm7y opened this issue May 17, 2022 · 3 comments

Comments

@pm7y
Copy link

pm7y commented May 17, 2022

Is it possible to update peer dependency on mobx to include v6?

    "mobx": "^6.3.5",
    "mobx-devtools-mst": "^0.9.30",
npm ERR! Could not resolve dependency:
npm ERR! peer mobx@"^2.2.0 || ^3.0.0 || ^4.0.0 || ^5.0.0" from [email protected]
npm ERR! node_modules/mobx-devtools-mst
npm ERR!   mobx-devtools-mst@"^0.9.30" from the root project
@beepsoft
Copy link

beepsoft commented Apr 27, 2023

Do you guys have a workaround for this?

Interestingly, when using yarn (v1) instead of npm, there's no such error, only a warning:

warning " > [email protected]" has incorrect peer dependency "mobx@^2.2.0 || ^3.0.0 || ^4.0.0 || ^5.0.0".

@basicdays
Copy link

basicdays commented Apr 27, 2023

A workaround I found is to add an overrides config in the package.json when using a modern version of npm.

...
	"overrides": {
		"mobx": "$mobx"
	},
...

You can read more about that setting here: https://docs.npmjs.com/cli/v9/configuring-npm/package-json#overrides

With that being said, I have no idea if mobx-devtools-mst can handle the current versions of mobx or mobx-state-tree.

@coolsoftwaretyler
Copy link
Collaborator

We have a PR open for this now! #130.

Gonna check on a small change, but should be merging soon. Sorry for the delay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants