fix: fix a potential ArgumentOutOfRangeException that could occur when changing the FontAsset in TextMeshPro

mob-sakai · mob-sakai · commit 3b095bcebd8b · 2025-04-07T07:39:18.000+09:00
close #327
diff --git a/Packages/src/Runtime/Internal/Extensions/MeshExtensions.cs b/Packages/src/Runtime/Internal/Extensions/MeshExtensions.cs
@@ -115,7 +115,8 @@ public static void CopyTo(this Mesh self, VertexHelper dst, int vertexCount, int
                     normals.GetOrDefault(i), tangents.GetOrDefault(i));
             }
 
-            for (var i = 0; i < indexCount - 2; i += 3)
+            var count = Mathf.Clamp(indexCount, 0, indices.Count);
+            for (var i = 0; i < count - 2; i += 3)
             {
                 dst.AddTriangle(indices[i], indices[i + 1], indices[i + 2]);
             }

Original file line number	Diff line number	Diff line change
`@@ -115,7 +115,8 @@ public static void CopyTo(this Mesh self, VertexHelper dst, int vertexCount, int`
`115`	`115`	`normals.GetOrDefault(i), tangents.GetOrDefault(i));`
`116`	`116`	`}`
`117`	`117`
`118`		`- for (var i = 0; i < indexCount - 2; i += 3)`
	`118`	`+ var count = Mathf.Clamp(indexCount, 0, indices.Count);`
	`119`	`+ for (var i = 0; i < count - 2; i += 3)`
`119`	`120`	`{`
`120`	`121`	`dst.AddTriangle(indices[i], indices[i + 1], indices[i + 2]);`
`121`	`122`	`}`