Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tm_isdst should be modified in caller's structure #2

Open
mnp opened this issue Jan 13, 2015 · 0 comments
Open

tm_isdst should be modified in caller's structure #2

mnp opened this issue Jan 13, 2015 · 0 comments
Assignees
@mnp
Labels
bug

Comments

@mnp
Copy link
Owner

mnp commented Jan 13, 2015

System mktime sets tm_isdst to 0 or 1 if you pass in -1. We forget to do that.
A point test is needed here.
@mnp mnp added the bug label Jan 13, 2015
@mnp mnp self-assigned this Jan 13, 2015
mnp added a commit that referenced this issue Jan 30, 2015
@mnp
Improvements for issues #2
9a9a148 
- units now accurately reflect the tm_isdst return value
- partial fix to library so correct tm_isdst is returned on non-switchover days
- tm_isdst will continue to be wrong on dst switchover days until issue #1 is fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mnp mnp

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mnp