Add github actions build #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vstelmakh
commented
Dec 3, 2020
| uses: shivammathur/setup-php@v2 | ||
| with: | ||
| php-version: '7.4' | ||
| tools: composer:v1 |
There was a problem hiding this comment.
There are some package plugins incompatibilities with composer v2 at this moment, so I restricted it to v1.
staabm
reviewed
Dec 4, 2020
| - name: Validate composer.json and composer.lock | ||
| run: composer validate | ||
|
|
||
| - name: Prepare Composer cache vars |
There was a problem hiding this comment.
You could simplify this steps by using https://github.com/ramsey/composer-install
|
Thanks a lot! I'll merge anyway because I think it's a good improvement, and if you are able to send a new PR that simplifies the Composer steps, as suggested above, that's perfect! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding #141
This is simple github actions CI, running PHPUnit. Composer dependencies are cached by date. If there are no changes in dependencies - multiple builds at same day run faster.
See build example at repository fork.