Update: GDumb + minor fixes #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enet with exemplars)
btwardow
reviewed
Aug 9, 2022
Comment on lines
+77
to
+85
| for images, targets in trn_loader: | ||
| # Get exemplars | ||
| if len(self.exemplars_dataset) > 0: | ||
| # 2. Balanced batches | ||
| exemplar_indices = torch.randperm(len(self.exemplars_dataset))[:trn_loader.batch_size] | ||
| images_exemplars, targets_exemplars = default_collate([self.exemplars_dataset[i] | ||
| for i in exemplar_indices]) | ||
| images = torch.cat((images, images_exemplars), dim=0) | ||
| targets = torch.cat((targets, targets_exemplars), dim=0) |
There was a problem hiding this comment.
@mmasana if the trn_loader is overridden with the exemplar_dataset, why here we do the permutation and not simply use images/targets out of it? It's more like drawing samples with the repetition than balanced batches, right?
|
@btwardow I forgot to add a test for gdumb, can you add it? I'll check the comment you left and see if I can improve it |
|
Ok. Will add it.
On Aug 9, 2022, 17:11, at 17:11, Marc Masana ***@***.***> wrote:
***@***.*** I forgot to add a test for gdumb, can you add it? I'll check
…the comment you left and see if I can improve it
--
Reply to this email directly or view it on GitHub:
#20 (comment)
You are receiving this because you were mentioned.
Message ID: ***@***.***>
|
Adding missing function and unit tests
|
This will close #7 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added GDumb and some minor fixes