From bd316f44cddccea5e5ad64e4d13a1975ea96eef4 Mon Sep 17 00:00:00 2001 From: Maximilian Muecke Date: Thu, 25 Apr 2024 00:38:19 +0200 Subject: [PATCH] refactor: remove unnecessary test_true --- R/LearnerClustDiana.R | 2 +- R/LearnerClustPAM.R | 9 +++------ 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/R/LearnerClustDiana.R b/R/LearnerClustDiana.R index a41739f8..a4a7652b 100644 --- a/R/LearnerClustDiana.R +++ b/R/LearnerClustDiana.R @@ -55,7 +55,7 @@ LearnerClustDiana = R6Class("LearnerClustDiana", }, .predict = function(task) { - if (test_true(self$param_set$values$k > task$nrow)) { + if (self$param_set$values$k > task$nrow) { stopf("`k` needs to be between 1 and %s", task$nrow) } diff --git a/R/LearnerClustPAM.R b/R/LearnerClustPAM.R index 6b656b42..da9aa810 100644 --- a/R/LearnerClustPAM.R +++ b/R/LearnerClustPAM.R @@ -53,16 +53,13 @@ LearnerClustPAM = R6Class("LearnerClustPAM", private = list( .train = function(task) { if (!is.null(self$param_set$values$medoids)) { - if (test_true(length(self$param_set$values$medoids) != self$param_set$values$k)) { + if (length(self$param_set$values$medoids) != self$param_set$values$k) { stopf("number of `medoids`' needs to match `k`!") } - r = map_lgl(self$param_set$values$medoids, function(i) { - test_true(i <= task$nrow) && test_true(i >= 1L) - }) + r = map_lgl(self$param_set$values$medoids, function(i) i <= task$nrow && i >= 1L) if (sum(r) != self$param_set$values$k) { msg = sprintf("`medoids` need to contain valid indices from 1") - msg = sprintf("%s to %s (number of observations)!", msg, self$param_set$values$k) - stopf(msg) + stopf("%s to %s (number of observations)!", msg, self$param_set$values$k) } }