Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain test data used in fitting test #25

Open
jacobq opened this issue Oct 19, 2018 · 1 comment
Open

Explain test data used in fitting test #25

jacobq opened this issue Oct 19, 2018 · 1 comment

Comments

@jacobq
Copy link
Contributor

jacobq commented Oct 19, 2018

The test suite contains a set of points to fit without indicating where those numbers came from. Plotting them in Excel suggests that the 3rd value (y = 21.119) may be a typo (instead of y = 2.119).

The value added by a test suite is only as good as the tests are meaningful. Does anyone know where these data came from? Were they measured from some physical process? Were they generated by a mathematical model of some kind? etc.

y: [7.807, -3.74, 21.119, 2.382, 4.269, 41.57, 73.401, 98.535, 97.059, 92.147]

image

@jacobq
Copy link
Contributor Author

jacobq commented Oct 25, 2018

Oops, I just noticed that the data referenced here actually isn't the bennet5 data but rather the data used for sigmoid fitting. In any case, I think it deserves some clarification.

@jacobq jacobq changed the title Fix "Bennet5" data Explain test data used in fitting test Oct 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant