Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nested-mutations plugin adds omitted reference column #46

Open
frisi opened this issue Apr 7, 2021 · 1 comment
Open

nested-mutations plugin adds omitted reference column #46

frisi opened this issue Apr 7, 2021 · 1 comment

Comments

@frisi
Copy link

frisi commented Apr 7, 2021

when this plugin is enabled, a column that otherwise is omitted from the generated api is still present

to reproduce

create table articles
(
    id  int generated by default as identity primary key
);

create table article_drafts
(
    id     int references articles (id) on delete cascade,
    title  text
);
comment on column article_drafts.id is E'@omit update';

when plugins-nested-mutations is disabled the resulting updateArticleDraft mutation's path type ArticleDraftPatch does not have an id

when it is enabled, ArticleDraftPatch has a field id (but it gets ignored on updates)

expectation

i'd say if the id column is omitted from the update mutation by a smart tag, also this plugin should respect that.

the ArticleDraftPatch should neither have a field id: Int nor articleToId: ArticleDraftsIdFkeyInput

versions used

using version 1.1.0 with postgraphile 4.11.0

@HighLiuk
Copy link

Same problem here, still

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants