Skip to content

Improvement of conjunction handling #198

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 of 2 tasks
maxaalexeeva opened this issue Mar 19, 2021 · 0 comments
Open
1 of 2 tasks

Improvement of conjunction handling #198

maxaalexeeva opened this issue Mar 19, 2021 · 0 comments
Assignees

Comments

@maxaalexeeva
Copy link
Contributor

maxaalexeeva commented Mar 19, 2021

Cases currently not handled by untangleConj:

  • _ αs and αc are soil evaporation coefficient and crop transpiration coefficient, respectively._ (here, we extract two separate conjDefs with multiple variables attached one def and there is no way to know whether the definition should be attached to the first or the second var)
  • where RHmax and RHmin are maximum and minimum relative humidity, respectively (here, maximum is no included into the def)

Possible solutions:

  • allow mult defs in conjDefinitions and then, if equal number of vars and defs, align them as var1->def1, var2 -> def2, etc
  • if there are multiple vars but one def, check if there is a conjoined element to the left (then attach var 2 to this def) or a conjoined element to the right (then attach var 2 to this def); need to generalize this somehow to more than two conjoined elements, eg by checking the number of conjoined elements to the left and right.
  • to solve the 'maximum' example, might need to expand on conj_and or include that in the rule.
@maxaalexeeva maxaalexeeva self-assigned this Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant