-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AND / OR modes for filters #98
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For
DeadboltRouteModifierTagsFilter
Deadbolt does support multiple deadbolt route modifier tags for one route, which all have to pass to process the route (meaning it's
AND
and ignores thedeadbolt.java.constraint-mode
config). See #96.We might want to implement an
OR
mode as well.However that should be a different config than
deadbolt.java.constraint-mode
becauseAND
mode back then as well of course). Therefore we also don't needsomething like
PROCESS_FIRST_CONSTRAINT_ONLY
but onlyAND
andOR
.OR
the filter constraints butAND
the annotation constraints.For
DeadboltRoutePathFilter
Same here, we could add
AND
andOR
mode. Right now you can not even add multiple constraints for one route...What needs to be done is:
In
AuthorizedRoute
change theconstraint
field to be aList
:and maybe even add a
mode
field to be even able to set a different mode for each route:and of course add a mode config in
reference.conf
which defines the default for all routes. (Maybe share/use the same config likeDeadboltRouteModifierTagsFilter
above uses?)The text was updated successfully, but these errors were encountered: