You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is your feature request related to a problem? Please describe.
Every good piece of software has tests. We don't and it's a good chance to have them added.
Describe the solution you'd like
We could start with simple unit tests with the DOM API and terminal instance mocked.
Assert DOM changes being made under different edge cases & conditions. Assert correct instance fields have been mutated & modified. Assert keyboard events performing what they should perform under different conditions, etc.
Additional context
Vitest should be used as a test runner since we're already on Vite.
Here's a checklist:
Write minimal tests covering everything in src/api
Create an npm test script
Hook up into the test GH action workflow (after "Typecheck")
Is your feature request related to a problem? Please describe.
Every good piece of software has tests. We don't and it's a good chance to have them added.
Describe the solution you'd like
We could start with simple unit tests with the DOM API and terminal instance mocked.
Assert DOM changes being made under different edge cases & conditions. Assert correct instance fields have been mutated & modified. Assert keyboard events performing what they should perform under different conditions, etc.
Additional context
Vitest should be used as a test runner since we're already on Vite.
Here's a checklist:
src/api
test
scriptttty/.github/workflows/test.yml
Lines 18 to 19 in 879d889
Not a very trivial task, but we could start a discussion here and work on adding tests together.
The text was updated successfully, but these errors were encountered: