Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't build release artifacts due to cibuildwheel issue #1324

Closed
mkleehammer opened this issue Feb 5, 2024 · 11 comments
Closed

Can't build release artifacts due to cibuildwheel issue #1324

mkleehammer opened this issue Feb 5, 2024 · 11 comments
Assignees

Comments

@mkleehammer
Copy link
Owner

mkleehammer commented Feb 5, 2024

Cannot build wheels on Windows due to this error:

pypa/cibuildwheel#1748

pypa/cibuildwheel#1740

Unfortunately, it says it is fixed in v2.16.5, but that is the version we are using.

@mkleehammer
Copy link
Owner Author

@keitherskine Have you run into this? Any ideas?

@mkleehammer
Copy link
Owner Author

The #1740 comment indicates it is sporadic for them. Maybe GH is running different runner versions?

@mkleehammer
Copy link
Owner Author

mkleehammer commented Feb 5, 2024

Now I'm getting something else: Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/upload-artifact@v3. For more information see:

It appears GH is not being consistent.

This is a warning that I believe is coming from the setup-qemu action, which uses node. The action has already been updated and we're using the latest version. It really seems like GH might be using old versions of actions? That would be such a huge bug I really doubt it.

@keitherskine
Copy link
Collaborator

keitherskine commented Feb 5, 2024

I haven't seen this. To test, I have manually kicked off the artifacts build for tag 5.1.0 (on mkleehammer/pyodbc). Let's see if it completes successfully. On my pyodbc fork, I didn't see an error after I updated the versions of the Github Action utilities.

@keitherskine
Copy link
Collaborator

Build run: https://github.com/mkleehammer/pyodbc/actions/runs/7787826214
Takes about 10-15 minutes.

@mkleehammer
Copy link
Owner Author

Your build is already past the error I'm seeing: https://github.com/mkleehammer/pyodbc/actions/runs/7769781696/job/21236111461

@keitherskine
Copy link
Collaborator

keitherskine commented Feb 5, 2024

That build has completed and the zip files of wheels can be downloaded.

The previous build failed but that was based on commit bc5b7c6 which is not tag 5.1.0 (commit f075e33). Is that the issue?

@keitherskine
Copy link
Collaborator

Meanwhile, the Appveyor build tests for tag 5.1.0 has completed:
https://ci.appveyor.com/project/mkleehammer/pyodbc/builds/49115239

@mkleehammer
Copy link
Owner Author

mkleehammer commented Feb 5, 2024

I've uploaded the binaries from your build. I'm going to close this. If the new GH workflow is having issues, I'm sure they'll be worked out before we need them again.

@keitherskine
Copy link
Collaborator

Great stuff! pyodbc appears to work on my M1 now "clean":

(pyodbc) /Users/keith/git/pyodbc $ python -m pip install pyodbc
Collecting pyodbc
  Downloading pyodbc-5.1.0-cp311-cp311-macosx_11_0_arm64.whl.metadata (2.7 kB)
Downloading pyodbc-5.1.0-cp311-cp311-macosx_11_0_arm64.whl (71 kB)
   ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 71.6/71.6 kB 3.3 MB/s eta 0:00:00
Installing collected packages: pyodbc
Successfully installed pyodbc-5.1.0
(pyodbc) Users/keith/git/pyodbc $ python -c "import pyodbc; print(pyodbc.version)"
5.1.0
(pyodbc) /Users/keith/git/pyodbc $ 

@keitherskine
Copy link
Collaborator

By the way, @mkleehammer , I have updated the Wiki release notes which were rather out-of-date. They should be accurate now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants