Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linting workflow for python code to keep code quality high #264

Closed
1 task done
rockett-m opened this issue Jun 10, 2024 · 0 comments · Fixed by #265
Closed
1 task done

Add linting workflow for python code to keep code quality high #264

rockett-m opened this issue Jun 10, 2024 · 0 comments · Fixed by #265
Assignees
@rockett-m
Labels
enhancement/build-system Improves an aspect of the build system

Comments

@rockett-m
Copy link
Contributor

Abstract

This proposal would add automatic python code checking according to pep-8 standards.

Description

This proposal would add automatic python code checking according to pep-8 standards. I would make any syntax/style errors to not cause failure but to be visible in the report. This would be enabled for pull-requests and pushes. The user could also run this check from command line before making a formal commit. This will show all linting violations and rate all the python code out of 10. Later we could enforce a minimum rating out of 10 for new python file uploads or changes.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@rockett-m rockett-m added the feedback/logistics A suggested change in the project's governance or model of collaboration label Jun 10, 2024
@HalosGhost HalosGhost assigned rockett-m and unassigned HalosGhost Jun 10, 2024
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jun 10, 2024
@rockett-m
Added python linting workflow for quality code; issue mit-dci#264
85d314c 
Signed-off-by: Morgan Rockett <[email protected]>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jun 10, 2024
@rockett-m
Added python linting workflow for quality code; issue mit-dci#264
795ecf1 
Signed-off-by: Morgan Rockett <[email protected]>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jun 10, 2024
@rockett-m
Added python linting workflow for quality code; issue mit-dci#264
f1f06a4 
Signed-off-by: Morgan Rockett <[email protected]>
@rockett-m rockett-m mentioned this issue Jun 10, 2024
Merged
@HalosGhost HalosGhost linked a pull request Jun 11, 2024 that will close this issue
Add python linting workflow to check quality of python code #265
Merged
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jun 11, 2024
@rockett-m
Added python linting workflow for quality code; issue mit-dci#264
3ae77ce 
Signed-off-by: Morgan Rockett <[email protected]>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jun 11, 2024
@rockett-m
Added python linting workflow for quality code; issue mit-dci#264
6366315 
Signed-off-by: Morgan Rockett <[email protected]>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jun 11, 2024
@rockett-m
Added python linting workflow for quality code; issue mit-dci#264
8699f05 
Signed-off-by: Morgan Rockett <[email protected]>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jun 11, 2024
@rockett-m
Added python linting workflow for quality code; issue mit-dci#264
bb7daf5 
Signed-off-by: Morgan Rockett <[email protected]>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jun 12, 2024
@rockett-m
Added python linting workflow for quality code; issue mit-dci#264
a90a0a8 
Signed-off-by: Morgan Rockett <[email protected]>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jun 12, 2024
@rockett-m
Added python linting workflow for quality code; issue mit-dci#264
471c5ee 
Signed-off-by: Morgan Rockett <[email protected]>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jun 12, 2024
@rockett-m
Added python linting workflow for quality code; issue mit-dci#264
7e17ecb 
Signed-off-by: Morgan Rockett <[email protected]>
@HalosGhost HalosGhost added enhancement/build-system Improves an aspect of the build system and removed feedback/logistics A suggested change in the project's governance or model of collaboration labels Jun 13, 2024
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jun 21, 2024
@rockett-m
Added python linting workflow for quality code; issue mit-dci#264
b523070 
This commit made with the help of github copilot

Signed-off-by: Morgan Rockett <[email protected]>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jun 24, 2024
@rockett-m
Added python linting to enforce code quality; issue mit-dci#264
7d700b8 
This commit made with the assistance of github copilot

Signed-off-by: Morgan Rockett <[email protected]>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jun 25, 2024
@rockett-m
Added python linting to enforce code quality; issue mit-dci#264
00531fa 
This commit made with the assistance of github copilot

Signed-off-by: Morgan Rockett <[email protected]>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jun 25, 2024
@rockett-m
Added python linting to enforce code quality; issue mit-dci#264
efbb6fd 
This commit made with the assistance of github copilot

Signed-off-by: Morgan Rockett <[email protected]>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jun 25, 2024
@rockett-m
Added python linting to enforce code quality; issue mit-dci#264
926cc33 
This commit made with the assistance of github copilot

Signed-off-by: Morgan Rockett <[email protected]>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jun 25, 2024
@rockett-m
Added python linting to enforce code quality; issue mit-dci#264
58c55d3 
This commit made with the assistance of github copilot

Signed-off-by: Morgan Rockett <[email protected]>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jun 26, 2024
@rockett-m
Added python linting to enforce code quality; issue mit-dci#264
8957f60 
This commit made with the assistance of github copilot

Signed-off-by: Morgan Rockett <[email protected]>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jun 26, 2024
@rockett-m
ci: added python linting to enforce code quality; issue mit-dci#264
8fe4d1a 
This commit made with the assistance of github copilot

Signed-off-by: Morgan Rockett <[email protected]>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jun 26, 2024
@rockett-m
ci: added python linting to enforce code quality; issue mit-dci#264
fc895ea 
This commit made with the assistance of github copilot

Signed-off-by: Morgan Rockett <[email protected]>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jun 27, 2024
@rockett-m
ci: added python linting to enforce code quality; issue mit-dci#264
80a3876 
This commit made with the assistance of github copilot

Signed-off-by: Morgan Rockett <[email protected]>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jun 27, 2024
@rockett-m
ci: added python linting to enforce code quality; issue mit-dci#264
18f0ac2 
This commit made with the assistance of github copilot

Signed-off-by: Morgan Rockett <[email protected]>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jun 28, 2024
@rockett-m
ci: added python linting to enforce code quality; issue mit-dci#264
9d2269a 
This commit made with the assistance of github copilot

Signed-off-by: Morgan Rockett <[email protected]>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jun 28, 2024
@rockett-m
ci: added python linting to enforce code quality; issue mit-dci#264
9dfe679 
This commit made with the assistance of github copilot

Signed-off-by: Morgan Rockett <[email protected]>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jun 28, 2024
@rockett-m
ci: added python linting to enforce code quality; issue mit-dci#264
b0e9dee 
This commit made with the assistance of github copilot

Signed-off-by: Morgan Rockett <[email protected]>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jul 1, 2024
@rockett-m
ci: added python linting to enforce code quality; issue mit-dci#264
1990468 
This commit made with the assistance of github copilot

Signed-off-by: Morgan Rockett <[email protected]>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jul 1, 2024
@rockett-m
ci: added python linting to enforce code quality; issue mit-dci#264
8f9f378 
This commit made with the assistance of github copilot

Signed-off-by: Morgan Rockett <[email protected]>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jul 2, 2024
@rockett-m
ci: added python linting to enforce code quality; issue mit-dci#264
de7e810 
This commit made with the assistance of github copilot

Signed-off-by: Morgan Rockett <[email protected]>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jul 2, 2024
@rockett-m
ci: added pylint in github workflow to enforce code quality; fixes mi…
e660653 
…t-dci#264

This commit made with the assistance of github copilot

Signed-off-by: Morgan Rockett <[email protected]>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jul 2, 2024
@rockett-m
ci: added pylint in github workflow to enforce code quality; fixes mi…
3c94678 
…t-dci#264

This commit made with the assistance of github copilot

Signed-off-by: Morgan Rockett <[email protected]>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jul 8, 2024
@rockett-m
ci: added pylint in github workflow to enforce code quality; fixes mi…
d57344a 
…t-dci#264

This commit made with the assistance of github copilot

Signed-off-by: Morgan Rockett <[email protected]>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jul 9, 2024
@rockett-m
ci: added pylint in github workflow to enforce code quality; fixes mi…
b2a46ef 
…t-dci#264

This commit made with the assistance of github copilot

Signed-off-by: Morgan Rockett <[email protected]>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jul 10, 2024
@rockett-m
ci: added pylint in github workflow to enforce code quality; fixes mi…
a75b1d9 
…t-dci#264

This commit made with the assistance of github copilot

Signed-off-by: Morgan Rockett <[email protected]>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jul 15, 2024
@rockett-m
ci: added pylint in github workflow to enforce code quality; fixes mi…
ee6b889 
…t-dci#264

This commit made with the assistance of github copilot

Signed-off-by: Morgan Rockett <[email protected]>
rockett-m added a commit to rockett-m/opencbdc-tx that referenced this issue Jul 17, 2024
@rockett-m
ci: added pylint in github workflow to enforce code quality; fixes mi…
e975677 
…t-dci#264

This commit made with the assistance of github copilot

Signed-off-by: Morgan Rockett <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rockett-m rockett-m

Labels
enhancement/build-system Improves an aspect of the build system
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add python linting workflow to check quality of python code rockett-m/opencbdc-tx
2 participants
@HalosGhost @rockett-m