Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.12 support #627

Open
hyve9 opened this issue Mar 16, 2024 · 1 comment
Open

Python 3.12 support #627

hyve9 opened this issue Mar 16, 2024 · 1 comment

Comments

@hyve9
Copy link

hyve9 commented Mar 16, 2024

It looks like mirdata still depends on imp, which was deprecated in 3.11 and removed in 3.12:

pip install mirdata 
Collecting mirdata
  Using cached mirdata-0.3.8-py3-none-any.whl.metadata (6.6 kB)
Collecting attrs>=23.1.0 (from mirdata)
  Using cached attrs-23.2.0-py3-none-any.whl.metadata (9.5 kB)
Collecting black>=23.3.0 (from mirdata)
  Using cached black-24.3.0-cp312-cp312-manylinux_2_17_x86_64.manylinux2014_x86_64.whl.metadata (75 kB)
Collecting chardet>=5.0.0 (from mirdata)
  Using cached chardet-5.2.0-py3-none-any.whl.metadata (3.4 kB)
Collecting Deprecated>=1.2.14 (from mirdata)
  Using cached Deprecated-1.2.14-py2.py3-none-any.whl.metadata (5.4 kB)
Collecting jams>=0.3.4 (from mirdata)
  Using cached jams-0.3.4.tar.gz (51 kB)
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error
  
  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [6 lines of output]
      Traceback (most recent call last):
        File "<string>", line 2, in <module>
        File "<pip-setuptools-caller>", line 34, in <module>
        File "/tmp/pip-install-gavk7r0k/jams_b471981ad2754869a2455feefe6ac42e/setup.py", line 3, in <module>
          import imp
      ModuleNotFoundError: No module named 'imp'
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

Recommend to replace imp with importlib: https://docs.python.org/3/library/importlib.html#module-importlib

@hyve9
Copy link
Author

hyve9 commented Mar 24, 2024

Actually, it's not mirdata - mirdata already supports 3.12. It's Jams (https://github.com/marl/jams). This PR should resolve:
marl/jams#215

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant