Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor Filosax note class #558

Open
nkundiushuti opened this issue Oct 4, 2022 · 1 comment
Open

refactor Filosax note class #558

nkundiushuti opened this issue Oct 4, 2022 · 1 comment
Labels
enhancement New feature or request priority Issues with this tag will be addressed before others.

Comments

@nkundiushuti
Copy link
Collaborator

we have a an annotation class and a NoteData class inside annotations https://github.com/mir-dataset-loaders/mirdata/blob/master/mirdata/annotations.py
ideally the Note class in filosax should should have been inherited Annotation/NoteData
@nkundiushuti nkundiushuti added the enhancement New feature or request label Oct 4, 2022
@magdalenafuentes magdalenafuentes added the priority Issues with this tag will be addressed before others. label Nov 2, 2022
@magdalenafuentes
Copy link
Collaborator

Hey @dave-foster can you get in touch with us regarding Filosax? Please drop us a line at mfuentes [at] nyu [dot] edu or harsh.palan [at] nyu [dot] edu

@genisplaja genisplaja mentioned this issue Mar 7, 2023
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request priority Issues with this tag will be addressed before others.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nkundiushuti @magdalenafuentes